This repository was archived by the owner on Mar 25, 2021. It is now read-only.
Added allow-generics option to invalid-void rule#4839
Merged
adidahiya merged 6 commits intopalantir:masterfrom Sep 9, 2019
JoshuaKGoldberg:invalid-void-generics
Merged
Added allow-generics option to invalid-void rule#4839adidahiya merged 6 commits intopalantir:masterfrom JoshuaKGoldberg:invalid-void-generics
adidahiya merged 6 commits intopalantir:masterfrom
JoshuaKGoldberg:invalid-void-generics
Conversation
adidahiya
suggested changes
Sep 4, 2019
Contributor
adidahiya
left a comment
adidahiya
left a comment
There was a problem hiding this comment.
code looks good, let's just improve the error messages a bit
Thanks! Co-Authored-By: Adi Dahiya <adi.dahiya14@gmail.com>
Contributor
Author
|
Thanks @adidahiya - sorry about the delay! |
adidahiya
approved these changes
Sep 9, 2019
This was referenced Nov 13, 2019
This was referenced Mar 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
invalid void#4828Overview of change:
Adds an
allow-genericsoption toinvalid-voidfor the sake of common uses such asPromise<void>. It'strueby default, can be specified asfalse, and also allows astring[]whitelist: e.g."allow-generics": ["Promise"].CHANGELOG.md entry:
[new-rule-option]: Added allow-generics to invalid-void