This repository was archived by the owner on Mar 25, 2021. It is now read-only.
fix: add option to enforce alphabetical ordering regardless of blank lines#4808
Merged
adidahiya merged 2 commits intopalantir:masterfrom Jul 25, 2019
Merged
Conversation
vedadeepta
changed the title
vedadeepta
changed the title
adidahiya
suggested changes
Jul 25, 2019
Contributor
adidahiya
left a comment
adidahiya
left a comment
There was a problem hiding this comment.
looks good, but let's call the option "ignore-blank-lines"
adidahiya
approved these changes
Jul 25, 2019
This was referenced Mar 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Added a option
allow-blank-linesto ruleobject-literal-sort-keyswhich enforces alphabetical ordering regardless of blank lines between key/value pairs.Is there anything you'd like reviewers to focus on?
Not sure if the option name
allow-blank-linesis correct.CHANGELOG.md entry:
[new-rule-option]
ignore-blank-linesoption forobject-literal-sort-keysrule