This repository was archived by the owner on Mar 25, 2021. It is now read-only.
Allowed new 'AsyncGenerator' name for await-promise async iterables#4800
Merged
adidahiya merged 1 commit intopalantir:masterfrom Jul 24, 2019
JoshuaKGoldberg:ts-next-async-generator
Merged
Allowed new 'AsyncGenerator' name for await-promise async iterables#4800adidahiya merged 1 commit intopalantir:masterfrom JoshuaKGoldberg:ts-next-async-generator
adidahiya merged 1 commit intopalantir:masterfrom
JoshuaKGoldberg:ts-next-async-generator
Conversation
adidahiya
approved these changes
Jul 24, 2019
This was referenced Mar 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
[ ] Documentation updateOverview of change:
Allows the new
AsyncGeneratortype introduced in microsoft/TypeScript#30790 as one of the hardcoded names for async iterables.Is there anything you'd like reviewers to focus on?
Is this the right approach? I think so, but 🤷♂ hard to tell with these kind-of-sort-of breaking changes.
CHANGELOG.md entry: