This repository was archived by the owner on Mar 25, 2021. It is now read-only.
--print-config flag#4744
Merged
adidahiya merged 10 commits intopalantir:masterfrom Jun 3, 2019
JoshuaKGoldberg:print-config
Merged
--print-config flag#4744adidahiya merged 10 commits intopalantir:masterfrom JoshuaKGoldberg:print-config
adidahiya merged 10 commits intopalantir:masterfrom
JoshuaKGoldberg:print-config
Conversation
added 3 commits
May 25, 2019 16:04
…s.ts src/runner.ts is getting pretty overcrowded; it was getting hard to reason about where things belonged in it.
Relies on some slightly manual stringification of members of the config files.
Haven't figured out yet how to test the real output :(
Matches ESLint's.
added 2 commits
May 25, 2019 17:16
adidahiya
suggested changes
May 30, 2019
Contributor
adidahiya
left a comment
adidahiya
left a comment
There was a problem hiding this comment.
I will fix the next / RC failures today
adidahiya
approved these changes
Jun 3, 2019
This was referenced Mar 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Adds a
--print-configflag as suggested in #3720. It's roughly equivalent to ESLint's: it takes in a file name and prints the JSON result of parsing the configuration that would be used for that file.Is there anything you'd like reviewers to focus on?
Where should I add tests for the output of this? I could only find precedent for testing the exit code. 😕
Cleaned up
src/runner.tsa bit to help keep things organized. See first 3 commits in order for a more logical flow of the changes.Edit: managed to bust my local install of TSLint; fixing lint rules now... 😂RC and Next lint failures are unrelated: #4745CHANGELOG.md entry:
[enhancement]: Added --print-config CLI flag