[new-rule] Added new invalid-void rule by timocov · Pull Request #4736 · palantir/tslint

timocov · 2019-05-21T06:53:18Z

PR checklist

Addresses an existing issue: fixes New no-invalid-void rule #4732
New feature, bugfix, or enhancement
- Includes tests
Documentation update

Overview of change:

Added new rule no-invalid-void which fails on every "invalid" usage of the void type.

CHANGELOG.md entry:

[new-rule] no-invalid-void

Fixes #4732

JoshuaKGoldberg

Implementation generally looks good: some comments around semantics please!

src/rules/noInvalidVoidRule.ts

JoshuaKGoldberg

Looking good so far - mostly just interested in expanding the test coverage, since there are a lot of potential edge cases.

test/rules/invalid-void/test.ts.lint

src/rules/invalidVoidRule.ts

https://github.com/Microsoft/TypeScript/wiki/What's-new-in-TypeScript#generic-parameter-defaults

timocov · 2019-07-01T10:45:29Z

@JoshuaKGoldberg can you please take a look? Do I need to do fix something else?

JoshuaKGoldberg · 2019-07-01T11:25:38Z

Planning on looking at pending PRs this week!

JoshuaKGoldberg

Almost there 🙏 I promise!

src/language/rule/abstractRule.ts

…actWalker to undefined from {}

timocov · 2019-07-06T08:57:33Z

There is CI error, but it looks like the master is failed too.

JoshuaKGoldberg

Looks great to me. Thanks so much for sticking through the PR reviews @timocov! 🚀

timocov · 2019-07-06T14:37:56Z

🕺 thank you @JoshuaKGoldberg

buu700 · 2019-09-07T14:58:55Z

@timocov, is it expected that this complains about types like Promise<void>, and if so is Promise<undefined> the recommended style?

timocov · 2019-09-08T21:30:13Z

Hey @buu700, I don't think that it was intended and I don't think that Promise<undefined> is what I suggest to use instead either. For me, we should add exception for Promise<void> case (and PromiseLike<void> as well). @JoshuaKGoldberg what do you think?

adidahiya · 2019-09-08T22:59:47Z

@buu700 @timocov see #4832

buu700 · 2019-09-08T23:26:56Z

Whoops, sorry about the duplicate report, but thanks for the link!

JoshuaKGoldberg · 2019-09-08T23:33:23Z

Yup, this was an error on my end for not noticing in review. Updated the fix PR. It should be in soon

timocov added 2 commits May 21, 2019 09:51

[new-rule] Added new no-invalid-void rule

cc84811

Fixes #4732

[no-invalid-void] Fixed lint error

aa97759

JoshuaKGoldberg suggested changes May 25, 2019

View reviewed changes

JoshuaKGoldberg added the PR: waiting for author label May 25, 2019

timocov added 6 commits May 28, 2019 12:09

Merge branch 'master' into no-invalid-void-rule

39b4ede

[no-invalid-void] Changed copyright year

355e339

[no-invalid-void] Removed unnecessary checking parent of the node

60ed94a

[no-invalid-void] Fixed a long string

c80e995

[invalid-void] Renamed no-invalid-void rule to invalid-void

5ccb06f

[invalid-void] Added rationale

204c47c

JoshuaKGoldberg added PR: waiting for reviewer and removed PR: waiting for author labels Jun 1, 2019

JoshuaKGoldberg suggested changes Jun 1, 2019

View reviewed changes

test/rules/invalid-void/test.ts.lint Outdated Show resolved Hide resolved

test/rules/invalid-void/test.ts.lint Outdated Show resolved Hide resolved

src/rules/invalidVoidRule.ts Outdated Show resolved Hide resolved

src/rules/invalidVoidRule.ts Outdated Show resolved Hide resolved

JoshuaKGoldberg added PR: waiting for author and removed PR: waiting for reviewer labels Jun 1, 2019

timocov added 3 commits June 16, 2019 12:35

Merge branch 'master' into no-invalid-void-rule

a681205

[invalid-void] Changed failure string

b754115

[invalid-void] Changed failedKinds type from Array to Set

6b87399

timocov changed the title ~~[new-rule] Added new no-invalid-void rule~~ [new-rule] Added new invalid-void rule Jun 16, 2019

timocov added 2 commits June 16, 2019 13:49

[invalid-void] Added new kinds to fail

c8ff62e

[invalid-void] Fixed build for TypeScript < 2.3

03545dd

https://github.com/Microsoft/TypeScript/wiki/What's-new-in-TypeScript#generic-parameter-defaults

adidahiya added PR: waiting for reviewer and removed PR: waiting for author labels Jun 24, 2019

JoshuaKGoldberg suggested changes Jul 4, 2019

View reviewed changes

src/language/rule/abstractRule.ts Show resolved Hide resolved

JoshuaKGoldberg added PR: waiting for author and removed PR: waiting for reviewer labels Jul 4, 2019

timocov added 2 commits July 6, 2019 11:37

Merge branch 'master' into no-invalid-void-rule

b8b7a7d

[invalid-void] Replaced default generic type of WalkContext and Abstr…

0bff084

…actWalker to undefined from {}

JoshuaKGoldberg approved these changes Jul 6, 2019

View reviewed changes

JoshuaKGoldberg merged commit aa2af99 into palantir:master Jul 6, 2019

timocov deleted the no-invalid-void-rule branch July 6, 2019 14:37

adidahiya mentioned this pull request Aug 20, 2019

Prepare release v5.19.0 #4826

Merged

snyk-bot mentioned this pull request Oct 11, 2019

[Snyk] Upgrade tslint from 5.11.0 to 5.20.0 Narshe1412/nuarca-sql#21

Merged

snyk-bot mentioned this pull request Oct 26, 2019

[Snyk] Upgrade tslint from 5.12.1 to 5.20.0 ajesse11x/caprover#5

Open

snyk-bot mentioned this pull request Nov 15, 2019

[Snyk] Upgrade tslint from 5.8.0 to 5.20.1 Matthelonianxl/cli-build-app#7

Open

snyk-bot mentioned this pull request Dec 15, 2019

[Snyk] Upgrade tslint from 5.11.0 to 5.20.1 dyna-dot/arxiv-bib-overlay#1

Open

snyk-bot mentioned this pull request Feb 19, 2020

[Snyk] Upgrade tslint from 5.9.1 to 5.20.1 hmcts/vh-admin-web#230

Merged

snyk-bot mentioned this pull request Mar 31, 2020

[Snyk] Upgrade tslint from 5.8.0 to 5.20.1 baophucct/trust-ray#6

Open

snyk-bot mentioned this pull request Apr 12, 2020

[Snyk] Upgrade tslint from 5.18.0 to 5.20.1 speech4j/web#14

Closed

snyk-bot mentioned this pull request Apr 22, 2020

[Snyk] Upgrade tslint from 5.9.1 to 5.20.1 Narshe1412/APMTraining#19

Open

dependabot bot mentioned this pull request Mar 15, 2021

Bump tslint from 5.9.1 to 5.20.1 CartoonIsArt/CIAPI#130

Closed

christian-thiel-webcom mentioned this pull request Aug 10, 2024

[Snyk] Upgrade tslint from 5.14.0 to 5.20.1 webcomputing/tslint-config-webcomputing#7

Open

Conversation

timocov commented May 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR checklist

Overview of change:

CHANGELOG.md entry:

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

timocov commented Jul 1, 2019

Uh oh!

JoshuaKGoldberg commented Jul 1, 2019

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

timocov commented Jul 6, 2019

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

timocov commented Jul 6, 2019

Uh oh!

buu700 commented Sep 7, 2019

Uh oh!

timocov commented Sep 8, 2019

Uh oh!

adidahiya commented Sep 8, 2019

Uh oh!

buu700 commented Sep 8, 2019

Uh oh!

JoshuaKGoldberg commented Sep 8, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

timocov commented May 21, 2019 •

edited

Loading