This repository was archived by the owner on Mar 25, 2021. It is now read-only.
Add a fixer for "unnecessary-constructor" rule.#4694
Merged
JoshuaKGoldberg merged 2 commits intopalantir:masterfrom May 5, 2019
Merged
Add a fixer for "unnecessary-constructor" rule.#4694JoshuaKGoldberg merged 2 commits intopalantir:masterfrom
JoshuaKGoldberg merged 2 commits intopalantir:masterfrom
Conversation
JoshuaKGoldberg
approved these changes
May 5, 2019
Contributor
JoshuaKGoldberg
left a comment
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
...but removed later. What are the concerns?
Ha, I forgot about this! Thanks for adding it back in 😊
Until copying links to PR responses is fixed, quoting the comment left on the fixer as originally implemented:
This will produce invalid code for classes with an empty constructor and multiple overload signatures by removing the implementation and leaving the overloads in place.
It looks like you added the logic & test cases for deleting overloads so this LGTM. Thanks!
Merged
This was referenced Mar 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Add a fixer for "unnecessary-constructor" rule.
Also don't flag constructors with decorated parameters since the parameter decorator can have side effects.
Is there anything you'd like reviewers to focus on?
This was added in the initial commit of "unnecessary-constructor" rule but removed later. What are the concerns?
I ran this fixer across Google's mono repo. The fixes produced are legit to me.
CHANGELOG.md entry: