This repository was archived by the owner on Mar 25, 2021. It is now read-only.
no-magic-numbers rule ignores arguments in Number prototype methods#3668
Merged
JoshuaKGoldberg merged 7 commits intopalantir:masterfrom Jun 15, 2019
Merged
Conversation
jkillian
approved these changes
May 1, 2018
Contributor
jkillian
left a comment
There was a problem hiding this comment.
This looks good to me @mateuszwitkowski, thanks! Would you mind merging master into your branch so that the tests pass?
giladgray
suggested changes
May 1, 2018
giladgray
left a comment
There was a problem hiding this comment.
@mateuszwitkowski this is sweet! few small changes please.
|
@mateuszwitkowski please update this branch (fix build & merge conflicts) so we can review it, or close it if no longer relevant. we will close this if we do not hear from you in two weeks. |
Contributor
Author
|
@giladgray I've just updated this PR so it's ready to go. |
JoshuaKGoldberg
approved these changes
Nov 6, 2018
Contributor
|
👋 @mateuszwitkowski, just a heads up that this is merged in now and will be available in the next TSLint release. Sorry it took so long to get in! The changes look great. |
Contributor
Author
|
@JoshuaKGoldberg Great! Thanks for the notice :) |
This was referenced Mar 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
no-magic-numbersshould ignore various Number methods' params #3653Overview of change:
no-magic-numbers rule now ignores arguments in following default Number prototype methods:
CHANGELOG.md entry:
[enhancement]: no-magic-numbers rule ignores arguments passed into default Number methods