This repository was archived by the owner on Mar 25, 2021. It is now read-only.
Fix issue with case sensitivity of noUnusedVariable rule on Windows#2819
Merged
adidahiya merged 2 commits intopalantir:masterfrom May 24, 2017
Merged
Fix issue with case sensitivity of noUnusedVariable rule on Windows#2819adidahiya merged 2 commits intopalantir:masterfrom
adidahiya merged 2 commits intopalantir:masterfrom
Conversation
When TSLint is being used to provide as-you-type linting as in Angular IDE, incorrect configuration of program created in makeUnusedCheckedProgram function is causing whole functionality to blow up. The core of the issue is that SourceFiles are being assigned case sensitive path when program is recreated for TSLint validation, which later causes that wrong path to stick and file not found problems appear in whole IDE. Change-Id: I05bcf150393f96e28c48d3b0a9a20e96002e5446
Member
|
Thanks for your interest in palantir/tslint, @piotrtomiak! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
adidahiya
approved these changes
May 24, 2017
Contributor
adidahiya
left a comment
adidahiya
left a comment
There was a problem hiding this comment.
thanks @piotrtomiak! I added in some minor code style fixes.
Contributor
Author
|
Awesome, thanks for quick turnaround! |
This was referenced Sep 26, 2017
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
When TSLint is being used to provide as-you-type linting as in Angular IDE, incorrect configuration of program created in makeUnusedCheckedProgram function is causing whole functionality to blow up. The core of the issue is that SourceFiles are being assigned case sensitive path when program is recreated for TSLint validation, which later causes that wrong path to stick and file not found problems appear in whole IDE.
Is there anything you'd like reviewers to focus on?
CHANGELOG.md entry:
[bugfix] Fix issue with case sensitivity of noUnusedVariable rule on Windows