Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Allow null keyword in a type position #1277

Merged
merged 1 commit into from
May 27, 2016
Merged

Allow null keyword in a type position #1277

merged 1 commit into from
May 27, 2016

Conversation

jkillian
Copy link
Contributor

Fixes #1265

adidahiya
adidahiya reviewed May 27, 2016
View reviewed changes
src/rules/noNullKeywordRule.ts
this.addFailure(this.createFailure(node.getStart(), node.getWidth(), Rule.FAILURE_STRING));
}
}
}

function isPartOfType({ parent }: ts.Node) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe isPartOfTypeLiteral?

@adidahiya
Copy link
Contributor

lgtm

@jkillian jkillian merged commit c781f2d into next May 27, 2016
@jkillian jkillian deleted the nullInType branch May 27, 2016 17:41
nchen63 pushed a commit that referenced this pull request Nov 19, 2016
Allow null keyword in a type position (originally #1277)
1ab2f2b
nchen63 added a commit that referenced this pull request Nov 19, 2016
@nchen63
Allow null keyword in a type position (originally #1277) (#1745)
be864a1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkillian @adidahiya