-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New rule: jsx-curly-brace-presence #196
New rule: jsx-curly-brace-presence #196
Conversation
* basic test cases for enforcing absence
Thanks for your interest in palantir/tslint-react, @OlafMerkert! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
@OlafMerkert want to sign the CLA ? 🙏 |
I already signed the CLA, the Quality gate for that passes. I suppose it needs to be reviewed and approved by a maintainer? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm otherwise
@adidahiya Thank you for reviewing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's pretty close. you seem to have mixed array and object options syntaxes
Co-Authored-By: OlafMerkert <[email protected]>
Co-Authored-By: OlafMerkert <[email protected]>
Co-Authored-By: OlafMerkert <[email protected]>
Co-Authored-By: OlafMerkert <[email protected]>
@adidahiya make release with this one please) |
@b-fett I'll make a release this week... note that in the meantime, you can install an NPM package from a git branch (like this repo's master branch)... https://medium.com/@jonchurch/use-github-branch-as-dependency-in-package-json-5eb609c81f1a |
@adidahiya thanks for response. Unfortunately this post is not relevant. Since library written in Typescript, it needs to be compiled before use, not just add to package. |
@b-fett just released 4.1.0, please try it out |
Closes #149
Implements a new rule with option to either enforce or forbid curly braces around string literals.
Auto-Fix included.