[jsx-curly-spacing] False positive with render props

[danielkcz]

The following code is causing false positive on this rule.

tslint-react: 3.4.0

<Route
  children={({ location, history }) =>
    store.auth.isAuthenticated ? (
      <Redirect to={location.state.from} />
    ) : null
  } // Error here: There should be no space before } (jsx-curly-spacing)
/>

I might add that code is auto formatted by Prettier so I cannot write it differently :)

/cc @bolatovumar

[adidahiya]

There are many tslint rules which are incompatible with prettier. I suggest you use tslint-config-prettier to avoid any conflicts.

[danielkcz]

@adidahiya Well, it was merely a side note that I am using Prettier :) Imagine if someone would format their code this way manually and get the same error. In that case it's obviously a bug in the rule, don't you agree?

[adidahiya]

sure, I guess so... would accept PRs to fix this false positive. typically the rules in tslint-react are all used together, and that code wouldn't pass jsx-no-multiline-js anyway...

[bolatovumar]

I can probably take a look when I have some time.

…

On Tue, Jan 30, 2018 at 8:44 AM, Adi Dahiya ***@***.***> wrote: Reopened #140 <#140>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#140 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB2FVpF4aaiS5KkysCR2YJqA0QFl9joOks5tP0bDgaJpZM4RydY3> .

[peter50216]

Hi,
Can a new minor version be released that include this fix? Thanks.

[fqlx]

+1, seeing this issue as well.

[evenfrost]

Same here.

[bartvde]

Can we please have a release that fixes this?