Merged
Conversation
added 2 commits
February 26, 2019 14:08
vinooganesh
force-pushed
the
vg/revertBackToScala211
branch
from
1ac21ac to
3539def
Compare
robert3005
reviewed
Feb 27, 2019
| echo "Spark version is $VERSION" | ||
| VERSION_SET=$("$MVN" versions:set -DnewVersion=$VERSION | tail -n 1) | ||
| if [ "$MAKE_TGZ" == "true" ]; then | ||
| echo "Making spark-dist-$NAME-$VERSION.tgz" |
There was a problem hiding this comment.
I think this was right and previous thing was wrong
Author
There was a problem hiding this comment.
wait you're saying echo "Making spark-dist-$NAME-$VERSION.tgz" is correct, right?
robert3005
reviewed
Feb 27, 2019
| </dependency> | ||
| <dependency> | ||
| <groupId>org.apache.spark</groupId> | ||
| <artifactId>spark-avro_${scala.binary.version}</artifactId> |
Author
There was a problem hiding this comment.
seems like an artifact of the revert
robert3005
suggested changes
Feb 27, 2019
robert3005
left a comment
robert3005
left a comment
There was a problem hiding this comment.
I think for this kind of change it's better to just make the change and not make it a revert
| </dependency> | ||
| <dependency> | ||
| <groupId>org.apache.spark</groupId> | ||
| <artifactId>spark-avro_${scala.binary.version}</artifactId> |
|
|
||
| For instance, you can build the Spark Streaming module using: | ||
|
|
||
| ./build/mvn -pl :spark-streaming_{{site.SCALA_BINARY_VERSION}} clean install |
There was a problem hiding this comment.
changes to this file are probably wrong
vinooganesh
commented
Feb 27, 2019
dev/deps/spark-deps-hadoop-palantir
Outdated
| parquet-format-structures-1.12.0-palantir.4.jar | ||
| parquet-hadoop-1.12.0-palantir.4.jar | ||
| parquet-jackson-1.12.0-palantir.4.jar | ||
| parquet-column-1.12.0-palantir.1.jar |
added 2 commits
February 27, 2019 10:50
robert3005
approved these changes
Feb 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts back to using Scala 2.11