[SPARK-24488][SQL] Fix issue when generator is aliased multiple times #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the Analyzer throws an exception if your try to nest a generator. However, it special cases generators "nested" in an alias, and allows that. If you try to alias a generator twice, it is not caught by the special case, so an exception is thrown. This PR trims the unnecessary, non-top-level aliases, so that the generator is allowed. new tests in AnalysisSuite. Author: Brandon Krieger <[email protected]> Closes apache#21508 from bkrieger/bk/SPARK-24488.
bkrieger
changed the title
robert3005
suggested changes
Jul 23, 2018
robert3005
left a comment
robert3005
left a comment
There was a problem hiding this comment.
We shouldn't cherry pick unless it's an unmerged pr or something to fix the build. It becomes extremely hard to manage state once you start to selectively cherry-pick.
Author
|
That's fair. I tried to merge in all of upstream, but there are a few conflicts and I don't have the Spark knowledge to resolve them. Do you think you'd be able to merge in upstream soon? |
|
@bkrieger will do it today along with writeup so you can do future ones yourself |
Author
|
Sounds good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypicked from apache#21508.
Corresponding ticket: https://issues.apache.org/jira/browse/SPARK-24488.