Closed
Conversation
We want to stay with what's currently in palantir/master until the version in apache/master has caught up with what's in the k8s fork. Then we drop the code from the fork and begin using the Apache stuff again.
Merged
|
Think this makes sense. |
|
@ash211 already pushed that to my branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to stay with what's currently in palantir/master until the version in
apache/master has caught up with what's in the k8s fork. Then we drop the
code from the fork and begin using the Apache stuff again.
The code in apache and spark-on-k8s is largely in different package names which is why this revert ends up largely looking like deletes.
Procedure:
An addition to #299