Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new file permissions API #1739

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

esword
Copy link
Contributor

@esword esword commented Nov 14, 2024

Before this PR

the setFileMode of copy task is deprecated for gradle9. Using it causes gradle deprecation warnings which cause any nebula integration tests to fail.

Note that this repo still has the ignoreDeprecations flag set to true because tests use the GCV plugin which also has gradle9 issues. But at least this plugin will not directly cause tests in other repos to have deprecation issues.

After this PR

==COMMIT_MSG==
==COMMIT_MSG==

Possible downsides?

@changelog-app
Copy link

changelog-app bot commented Nov 14, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

use new file permissions API

Check the box to generate changelog(s)

  • Generate changelog entry

@esword
Copy link
Contributor Author

esword commented Nov 14, 2024

sigh... the new API is only available in >= 8.3 so this won't work while we support gradle7. will need to do a switch to determine what version we are running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant