sls-packaging no longer sets -XX:+UseContainerCpuShares

[carterkozak]

Before this PR

all jdk-11 through jdk-19 services set -XX:+UseContainerCpuShares unnecessarily. See the container support section of the go-java-launcher readme:

1. If -XX:ActiveProcessorCount is unset, it will be set based on the discovered cgroup configurations and host information to a value between 2 and the number of processors reported by the runtime. You can read more about the reasoning behind this here.

After this PR

This is part of a deprecation campaign to allow jvms in containers to use ergonomics profiles based on the host system as opposed to requests-based overrides.
==COMMIT_MSG==
sls-packaging no longer sets -XX:+UseContainerCpuShares
==COMMIT_MSG==

Possible downsides?

Removing UseContainerCpuShares will have no impact in the short term because go-java-launcher overrides the
ActiveProcessorCount property based on requests by default, unless container support is
disabled. An audit of uses of that flag shows primarily tests will be impacted, relatively low risk that this will impact services. In the off-chance it does make a change for services, the result will be the behavior that we ultimately want, without the slow rollout we intend for most products.

Alternatives

Originally I put together an implementation using a feature flag, but decided the additional complexity around configuration would do more harm than good. You can find the diff here.

If you aren't sure which way to do something, do it both ways and see which works better
— John Carmack

[changelog-app]

Generate changelog in changelog/@unreleased

What do the change types mean?

• feature: A new feature of the service.
• improvement: An incremental improvement in the functionality or operation of the service.
• fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
• break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
  and external consumers of the service's API (e.g. customer-written software or integrations).
• deprecation: Advertises the intention to remove service functionality without any change to the
  operation of the service itself.
• manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
  performing database surgery, ...) at the time of upgrade for it to succeed.
• migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?

• ❗The break and manual task changelog types will result in a major release!
• 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
• ✨ All others will result in a minor version release.

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

sls-packaging no longer sets -XX:+UseContainerCpuShares

Check the box to generate changelog(s)

• Generate changelog entry

[svc-autorelease]

Released 7.44.0