-
Notifications
You must be signed in to change notification settings - Fork 20
Add iterables package containing helper method for getting the only element in a collection #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Mattheo28
wants to merge
7
commits into
develop
Choose a base branch
from
mioannou/iterables
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7499684
add iterables class + tests
ebcba89
add option with custom message
991c98d
Add generated changelog entries
f53d83e
release own package
c52768d
spotless
47c8112
update README
c439c49
Update README.md
Mattheo28 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| type: improvement | ||
| improvement: | ||
| description: Add iterables package containing helper method for getting the only element in a collection | ||
| links: | ||
| - https://github.com/palantir/safe-logging/pull/520 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| apply from: "${rootDir}/gradle/publish-jar.gradle" | ||
| apply plugin: 'com.palantir.revapi' | ||
|
|
||
| dependencies { | ||
| api project(':safe-logging') | ||
| api project(':preconditions') | ||
| compileOnly 'com.google.code.findbugs:jsr305' | ||
| compile group: 'com.google.guava', name: 'guava' | ||
|
|
||
| testImplementation 'junit:junit' | ||
| testImplementation 'org.assertj:assertj-core' | ||
| } |
45 changes: 45 additions & 0 deletions
45
iterables/src/main/java/com/palantir/logsafe/Iterables.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| /* | ||
| * (c) Copyright 2018 Palantir Technologies Inc. All rights reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| /* | ||
| * Copyright (C) 2007 The Guava Authors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except | ||
| * in compliance with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software distributed under the License | ||
| * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express | ||
| * or implied. See the License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ | ||
| package com.palantir.logsafe; | ||
|
|
||
| import com.google.common.base.Preconditions; | ||
| import com.google.common.collect.Iterators; | ||
| import java.util.Collection; | ||
|
|
||
| public final class Iterables { | ||
| public static final String DEFAULT_ERROR_MESSAGE = "Expected exactly one element in collection"; | ||
|
|
||
| private Iterables() {} | ||
|
|
||
| public static <T, C extends Collection<T>> T getOnlyElement(C collection, Arg<?>... args) { | ||
| Preconditions.checkState(collection.size() == 1, DEFAULT_ERROR_MESSAGE, args); | ||
| return Iterators.getOnlyElement(collection.iterator()); | ||
| } | ||
| } | ||
47 changes: 47 additions & 0 deletions
47
iterables/src/test/java/com/palantir/logsafe/IterablesTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| /* | ||
| * (c) Copyright 2021 Palantir Technologies Inc. All rights reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.palantir.logsafe; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
| import static org.assertj.core.api.Assertions.assertThatThrownBy; | ||
|
|
||
| import com.google.common.collect.ImmutableSet; | ||
| import org.junit.Test; | ||
|
|
||
| public class IterablesTest { | ||
| @Test | ||
| public void getOnlyElementReturnsElement() { | ||
| String element = "element"; | ||
| assertThat(Iterables.getOnlyElement(ImmutableSet.of(element))).isEqualTo(element); | ||
| } | ||
|
|
||
| @Test | ||
| public void getOnlyElementThrowsIfMoreThanOneElement() { | ||
| String element1 = "element1"; | ||
| String element2 = "element2"; | ||
| assertThatThrownBy(() -> Iterables.getOnlyElement(ImmutableSet.of(element1, element2))) | ||
| .isInstanceOf(IllegalStateException.class) | ||
| .hasMessageContaining(Iterables.DEFAULT_ERROR_MESSAGE); | ||
| } | ||
|
|
||
| @Test | ||
| public void getOnlyElementThrowsIfEmpty() { | ||
| assertThatThrownBy(() -> Iterables.getOnlyElement(ImmutableSet.of())) | ||
| .isInstanceOf(IllegalStateException.class) | ||
| .hasMessageContaining(Iterables.DEFAULT_ERROR_MESSAGE); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a collection, not an iterable. Guava Iterables takes an iterable, and iterators takes an iterator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah looks like i mixed the two together -- I'd be happy to implement this for both Iterables and Iterators