Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use submodule imports for lodash-es #3594

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Use submodule imports for lodash-es #3594

merged 1 commit into from
Nov 22, 2021

Conversation

michael-yx-wu
Copy link
Contributor

@michael-yx-wu michael-yx-wu commented Nov 19, 2021 •
edited
Loading

Reduces lodash-es dependency to about 25kb. Resolves #3588

Before:
Screen Shot 2021-11-19 at 5 15 36 PM

After:
Screen Shot 2021-11-19 at 5 10 16 PM

@michael-yx-wu
Use submodule imports for lodash-es
2ae2e11 
Reduces lodash-es dependency to about 25kb.
@blueprint-bot
Copy link

Use submodule imports for lodash-es

Demo: quicktests | fiddle

@michael-yx-wu michael-yx-wu mentioned this pull request Nov 19, 2021
Closed
@billytrend billytrend self-requested a review November 22, 2021 13:14
@billytrend billytrend self-requested a review November 22, 2021 13:39
@billytrend billytrend merged commit eb812f6 into develop Nov 22, 2021
@billytrend billytrend deleted the mw/lodash-again branch November 22, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billytrend billytrend billytrend approved these changes

@styu styu Awaiting requested review from styu

@adidahiya adidahiya Awaiting requested review from adidahiya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to lodash-es
3 participants
@michael-yx-wu @blueprint-bot @billytrend