Update extents after setBounds #3552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will trigger the 'updateExtents' method of a plot after its bounds are set. This is necessary because some scales, such as quantitative, will use the scale to add add padding to a domain in a proportional manner requiring the scale to have a valid domain and range. When the plots are anchored to an element with zero size or hidden with `display: none` the collapsed range causes invalid padding values to set the domain. This change will ensure that when the component finally has a valid size, the domains are updated correctly.
Update extents after setBoundsDemo: quicktests | fiddle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will trigger the 'updateExtents' method of a plot after
its bounds are set.
This is necessary because some scales, such as quantitative, will
use the scale to add add padding to a domain in a proportional manner
requiring the scale to have a valid domain and range.
When the plots are anchored to an element with zero size or hidden
with
display: nonethe collapsed range causes invalid padding valuesto set the domain.
This change will ensure that when the component finally has a valid
size, the domains are updated correctly.