Skip to content
This repository was archived by the owner on Sep 2, 2024. It is now read-only.

Revert "PARQUET-1529: Shade fastutil in all modules where used (#617)"#40

Closed
mccheah wants to merge 1 commit intomasterfrom
revert-spark-1529
Closed

Revert "PARQUET-1529: Shade fastutil in all modules where used (#617)"#40
mccheah wants to merge 1 commit intomasterfrom
revert-spark-1529

Conversation

@mccheah
Copy link
Copy Markdown

@mccheah mccheah commented Mar 14, 2019

This reverts commit dcfd53a.

Workaround for https://issues.apache.org/jira/browse/PARQUET-1544.

@mccheah
Copy link
Copy Markdown
Author

mccheah commented Mar 14, 2019

@sjrand @robert3005 for SA. Needed for some Iceberg experimentation, but unsure if this is going to impact anything else that depends on Parquet more generally.

@mccheah
Copy link
Copy Markdown
Author

mccheah commented Mar 14, 2019

Or @vinooganesh also. I'd like someone to sign off on this before merging, at least walking through the thought experiment on whether or not this revert could break anything.

@vinooganesh
Copy link
Copy Markdown

hey @mccheah, I'm not sure I know this code-path well enough to feel comfortable doing the revert. Will let @sjrand @robert3005 weigh in

@mccheah
Copy link
Copy Markdown
Author

mccheah commented Mar 18, 2019

Favoring #41 instead of this.

@mccheah mccheah closed this Mar 18, 2019
@mccheah mccheah deleted the revert-spark-1529 branch March 18, 2019 19:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants