This repository was archived by the owner on Jul 22, 2022. It is now read-only.
Bump to newer version of codahale/dropwizard metrics-core#33
Merged
sjrand merged 1 commit intobranch-2.9.0from Nov 30, 2017
Merged
Bump to newer version of codahale/dropwizard metrics-core#33sjrand merged 1 commit intobranch-2.9.0from
sjrand merged 1 commit intobranch-2.9.0from
Conversation
This version is 4.5 years old, and the project has since changed maven coordinates without changing package names. Much easier to update this to the new package name once in Palantir Hadoop rather than in all consumers.
robert3005
approved these changes
Nov 29, 2017
robert3005
left a comment
robert3005
left a comment
There was a problem hiding this comment.
Going to assume that these are all the occurrences
|
In Hadoop's defence, the version was recent when the dep was first introduced in https://issues.apache.org/jira/browse/YARN-1021. Looks like https://issues.apache.org/jira/browse/YARN-4811 added the dependency to I didn't see any test failures that looked out of the ordinary (there are always test failures), so I think this should be good. @ash211, want to upstream this as well? |
Author
|
Looks like it's already filed upstream at https://issues.apache.org/jira/browse/HADOOP-14652 with patch identical to what I did :) |
sjrand
pushed a commit
that referenced
this pull request
Dec 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This version is 4.5 years old, and the project has since changed maven
coordinates without changing package names. Much easier to update this to the
new package name once in Palantir Hadoop rather than in all consumers.