Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set JAVA_HOME in gradle-jdks-setup script #447

Merged
merged 14 commits into from
Oct 25, 2024
Merged

Set JAVA_HOME in gradle-jdks-setup script #447

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d2fab83
set java home
crogoz Oct 24, 2024
bcbcb4b
fix no java_home set
crogoz Oct 24, 2024
b97f469
Add generated changelog entries
svc-changelog Oct 24, 2024
1cf1a67
set
crogoz Oct 24, 2024
4cdd6c7
Merge branch 'cr/java-home' of github.com:palantir/gradle-jdks into c…
crogoz Oct 24, 2024
39acc92
set
crogoz Oct 24, 2024
e269cf6
checl
crogoz Oct 24, 2024
6794c75
test hava_home
crogoz Oct 24, 2024
fa57ae2
add certs
crogoz Oct 24, 2024
8c2a628
add certs
crogoz Oct 24, 2024
0726559
java home
crogoz Oct 24, 2024
b6bb8d8
test output
crogoz Oct 24, 2024
6f1043b
gradlew patch
crogoz Oct 25, 2024
6f9a3e7
fix output format
crogoz Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix output format
  • Loading branch information
@crogoz
crogoz committed Oct 25, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit 6f9a3e7d53ea830c1140fd3a81b344e7bf658e45
2 changes: 1 addition & 1 deletion ...onTest/java/com/palantir/gradle/jdks/setup/GradleJdkInstallationSetupIntegrationTest.java
View file
Original file line number Diff line number Diff line change
@@ -174,7 +174,7 @@ private void dockerBuildAndRunTestingScript(String baseImage, String shell, bool
assertThat(runCommandWithZeroExitCode(
List.of("docker", "run", "--rm", dockerImage, shell, "/testing-script.sh")))
.contains("openjdk version \"11.0.21\"")
.contains("JAVA_HOME is set to /root/.gradle/gradle-jdks/amazon-corretto-11.0.21.9.1");
.contains("JAVA_HOME is set to: /root/.gradle/gradle-jdks/amazon-corretto-11.0.21.9.1");
}

private static String runCommandWithZeroExitCode(List<String> commandArguments)