Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped dependency versions #581

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

mikethecalamity
Copy link
Contributor

@mikethecalamity mikethecalamity commented Mar 21, 2022

Before this PR

Issue is described at length: #468

After this PR

Usages of git-version on submodules no longer errors out.

Possible downsides?

New versions have breaking changes to the used APIs.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/gradle-git-version, @mweber03! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@changelog-app
Copy link

changelog-app bot commented Mar 21, 2022

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Bumped dependency versions

Before this PR

#468

After this PR

The above issue should be fixed.

Possible downsides?

None

Check the box to generate changelog(s)

  • Generate changelog entry

versions.props Outdated
com.google.guava:guava = 31.1-jre
org.immutables:* = 2.8.8
org.immutables:* = 2.9.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version has a known memory leak: immutables/immutables#1355

Let's bump only jgit in this change, and see what that does for us. A ./gradlew --write-locks will be necessary to update the versions.lock

Copy link
Contributor Author

@mikethecalamity mikethecalamity Mar 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done and done

@bulldozer-bot bulldozer-bot bot merged commit 16da4fa into palantir:develop Mar 21, 2022
@svc-autorelease
Copy link
Collaborator

Released 0.14.0

@robert3005 robert3005 mentioned this pull request Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants