Add check: Use Collection.isEmpty() instead of comparing size() with 0 #2530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
reviewed
Mar 28, 2023
baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/CollectionsIsEmpty.java
Outdated
Show resolved
Hide resolved
carterkozak
reviewed
Mar 28, 2023
baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/CollectionsIsEmpty.java
Outdated
Show resolved
Hide resolved
carterkozak
reviewed
Mar 28, 2023
baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/CollectionsIsEmpty.java
Outdated
Show resolved
Hide resolved
carterkozak
reviewed
Mar 28, 2023
baseline-error-prone/src/test/java/com/palantir/baseline/errorprone/CollectionsIsEmptyTest.java
Outdated
Show resolved
Hide resolved
carterkozak
reviewed
Mar 28, 2023
baseline-error-prone/src/test/java/com/palantir/baseline/errorprone/CollectionsIsEmptyTest.java
Outdated
Show resolved
Hide resolved
carterkozak
reviewed
Mar 28, 2023
baseline-error-prone/src/test/java/com/palantir/baseline/errorprone/CollectionsIsEmptyTest.java
Outdated
Show resolved
Hide resolved
carterkozak
reviewed
Mar 28, 2023
baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/CollectionsIsEmpty.java
Outdated
Show resolved
Hide resolved
carterkozak
reviewed
Mar 28, 2023
baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/CollectionsIsEmpty.java
Outdated
Show resolved
Hide resolved
…grate-refaster-templates-to-errorprone-rules
carterkozak
reviewed
Mar 30, 2023
baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/CardinalityEqualsZero.java
Outdated
Show resolved
Hide resolved
carterkozak
reviewed
Mar 30, 2023
baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/CardinalityEqualsZero.java
Outdated
Show resolved
Hide resolved
added 3 commits
March 30, 2023 17:25
…grate-refaster-templates-to-errorprone-rules
…ub.com:palantir/gradle-baseline into migrate-refaster-templates-to-errorprone-rules
carterkozak
reviewed
Mar 30, 2023
|
|
||
| private static boolean isExpressionThis(ExpressionTree tree) { | ||
| switch (tree.getKind()) { | ||
| case IDENTIFIER: |
Contributor
There was a problem hiding this comment.
I think the memberselect case is technically necessary here for "qualified this" usages e.g.
class Outer {
int foo();
Inner getInner() {
return new Inner();
}
class Inner {
int foo() {
// 'return foo()' would recurse infinitely
// this allows us to reference components on an enclosing class from a non-static inner class.
return Outer.this.foo();
}
}
}
Contributor
Author
There was a problem hiding this comment.
Ah. Have not seen this before. Updated, and added a test.
bulldozer-bot
bot
deleted the
migrate-refaster-templates-to-errorprone-rules
branch
Collaborator
|
Released 5.2.0 |
This was referenced Mar 31, 2023
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Apr 1, 2023
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 5.2.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Add check: Use Collection.isEmpty() instead of comparing size() with 0 | palantir/gradle-baseline#2530 | To enable or disable this check, please contact the maintainers of Excavator.
schlosna
reviewed
Apr 1, 2023
|
|
||
| EqualsZeroExpression equalsZeroExpression = maybeEqualsZeroExpression.get(); | ||
| ExpressionTree operand = equalsZeroExpression.operand(); | ||
| ExpressionTree collectionInstance = ASTHelpers.getReceiver(operand); |
Contributor
There was a problem hiding this comment.
Filed #2543
PR palantir/tritium#1688 is failing attempting to upgrade to gradle-baseline with this change on https://github.com/palantir/tritium/blob/13799047a8b715b4ebf395de80deed78a86b734c/tritium-registry/src/main/java/com/palantir/tritium/metrics/registry/TagMap.java#L120-L123
> Task :tritium-registry:compileJava FAILED
/home/circleci/project/tritium-registry/src/main/java/com/palantir/tritium/metrics/registry/TagMap.java:123: error: An unhandled exception was thrown by the Error Prone static analysis plugin.
if (comparisonResult == 0) {
^
Please report this at https://github.com/google/error-prone/issues/new and include the following:
error-prone version: 2.18.0
BugPattern: CardinalityEqualsZero
Stack Trace:
java.lang.IllegalStateException: Expected expression 'comparisonResult' to be a method invocation or field access, but was IDENTIFIER
at com.google.errorprone.util.ASTHelpers.getReceiver(ASTHelpers.java:605)
at com.palantir.baseline.errorprone.CardinalityEqualsZero.matchBinary(CardinalityEqualsZero.java:61)
at com.google.errorprone.scanner.ErrorProneScanner.processMatchers(ErrorProneScanner.java:449)
at com.google.errorprone.scanner.ErrorProneScanner.visitBinary(ErrorProneScanner.java:512)
at com.google.errorprone.scanner.ErrorProneScanner.visitBinary(ErrorProneScanner.java:150)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
We had a refaster template which suggested that
{implementation of Collection}.size() == 0be changed to{implementation of Collection}.isEmpty(). This was removed in this PR.After this PR
==COMMIT_MSG==
Add check: Use Collection.isEmpty() instead of comparing size() with 0
==COMMIT_MSG==