Implement ImmutableMapDuplicateKeyStrategy for obvious map construction #2416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
commented
Sep 30, 2022
...r-prone/src/main/java/com/palantir/baseline/errorprone/ImmutableMapDuplicateKeyStrategy.java
Outdated
Show resolved
Hide resolved
…prone/ImmutableMapDuplicateKeyStrategy.java
schlosna
approved these changes
Sep 30, 2022
Contributor
schlosna
left a comment
schlosna
left a comment
There was a problem hiding this comment.
Thanks for adding this. I'm curious to see the generated excavators as this rolls out.
Collaborator
|
Released 4.179.0 |
This was referenced Sep 30, 2022
Merged
This was referenced Sep 30, 2022
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Sep 30, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.179.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Implement ImmutableMapDuplicateKeyStrategy for obvious map construction. By default we suggest replacing `build()` with the more descriptive `buildOrThrow()`, however `buildKeepingLast()` may be the original intent in some cases. | palantir/gradle-baseline#2416 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==COMMIT_MSG==
Implement ImmutableMapDuplicateKeyStrategy for obvious map construction. By default we suggest replacing
build()with the more descriptivebuildOrThrow(), howeverbuildKeepingLast()may be the original intent in some cases.==COMMIT_MSG==
Possible downsides?
Code churn