Fix BaselineModuleJvmArgs with enable-preview functionality#2336
Merged
bulldozer-bot[bot] merged 2 commits intodevelopfrom Jul 29, 2022
Merged
Fix BaselineModuleJvmArgs with enable-preview functionality#2336bulldozer-bot[bot] merged 2 commits intodevelopfrom
bulldozer-bot[bot] merged 2 commits intodevelopfrom
Conversation
Generate changelog in
|
iamdanfox
commented
Jul 29, 2022
| BaselineJavaVersionsExtension javaVersionsExtension = | ||
| project.getExtensions().getByType(BaselineJavaVersionsExtension.class); | ||
| BaselineJavaVersionExtension javaVersionsExtension = | ||
| project.getExtensions().getByType(BaselineJavaVersionExtension.class); |
Contributor
Author
There was a problem hiding this comment.
the subtle typo here is that I was detecting that the singular BaselineJavaVersion plugin was applied, but trying to read the root level BaselineJavaVersionsExtension off this project.
This can only work in single project builds.
carterkozak
approved these changes
Jul 29, 2022
Collaborator
|
Released 4.150.0 |
This was referenced Jul 29, 2022
Merged
bulldozer-bot Bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Jul 29, 2022
###### _excavator_ is a bot for automating changes across repositories.
Changes produced by the roomba/latest-baseline-oss check.
# Release Notes
## 4.149.0
| Type | Description | Link |
| ---- | ----------- | ---- |
| Feature | Users of the `com.palantir.baseline-java-versions` plugin can now set `javaVersions { distributionTarget = '17_PREVIEW' }` to opt-in to Java's `--enable-preview` flag at compile time. | palantir/gradle-baseline#2322 |
## 4.150.0
| Type | Description | Link |
| ---- | ----------- | ---- |
| Fix | Fix the `BaselineModuleJvmArgs` plugin to once again work as intended in multi-project builds | palantir/gradle-baseline#2336 |
To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Jul 29, 2022
This was referenced Jul 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
I just tried to apply baseline 4.149.0 to template-witchcraft to try out my newly merged
--enable-previewstuff from #2322, but found a BUG:Turns out the tests I added were all single project tests and this obscured a mistake whereby multi-project builds would fail.
After this PR
==COMMIT_MSG==
Fix the
BaselineModuleJvmArgsplugin to once again work as intended in multi-project builds==COMMIT_MSG==
Possible downsides?