Streamline Throwable safety handling #2224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throwable are considered unsafe, and getMessage returns the safety of the throwable itself. This allows us to annotate a catch block as `@DoNotLog` in cases that an exception may contain credential information. This change also includes the guava `Throwables.getStackTraceAsString` utility as a safety-passthrough method.
Generate changelog in
|
fawind
approved these changes
Apr 25, 2022
Collaborator
|
Released 4.113.0 |
This was referenced Apr 25, 2022
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Apr 25, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.113.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Streamline Throwable safety handling | palantir/gradle-baseline#2224 | ## 4.114.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Disable intellij's ClassCanBeRecord inspection | palantir/gradle-baseline#2225 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Apr 25, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throwable are considered unsafe, and getMessage returns the
safety of the throwable itself. This allows us to annotate
a catch block as
@DoNotLogin cases that an exceptionmay contain credential information.
This change also includes the guava
Throwables.getStackTraceAsStringutility as a safety-passthroughmethod.
==COMMIT_MSG==
Streamline Throwable safety handling
==COMMIT_MSG==