Skip to content

Exclude internal ImmutablesStyle annotations from auto-imports and completion #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 5, 2021
Merged

Exclude internal ImmutablesStyle annotations from auto-imports and completion #1668

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8c1341
Exclude internal ImmutablesStyle annotations from auto-imports and co…
pkoenig10 Mar 5, 2021
e35b690
Add generated changelog entries
pkoenig10 Mar 5, 2021
3b2ed5d
Fix
pkoenig10 Mar 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/@unreleased/pr-1668.v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
type: improvement
improvement:
description: Internal `ImmutablesStyle` annotations are now excluded from Intellij auto-imports and completion.
links:
- https://github.com/palantir/gradle-baseline/pull/1668
7 changes: 5 additions & 2 deletions gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineIdea.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ class BaselineIdea extends AbstractBaselinePlugin {
addInspectionProjectProfile(node)
addJavacSettings(node)
addGitHubIssueNavigation(node)
ignoreCommonShadedPackages(node)
addExcludedAutoImports(node)
}
configureProjectForIntellijImport(rootProject)

Expand Down Expand Up @@ -430,7 +430,7 @@ class BaselineIdea extends AbstractBaselinePlugin {
}
}

private static void ignoreCommonShadedPackages(Node node) {
private static void addExcludedAutoImports(Node node) {
// language=xml
node.append(new XmlParser().parseText('''
<component name="JavaProjectCodeInsightSettings">
Expand All @@ -440,6 +440,9 @@ class BaselineIdea extends AbstractBaselinePlugin {
<name>autovalue.shaded</name>
<name>org.inferred.freebuilder.shaded</name>
<name>org.immutables.value.internal</name>
<name>com.palantir.conjure.java.client.config.ImmutablesStyle</name>
<name>com.palantir.sls.versionsImmutablesStyle</name>
<name>com.palantir.tokens.auth.ImmutablesStyle</name>
</excluded-names>
</component>
'''.stripIndent()))
Expand Down