-
Notifications
You must be signed in to change notification settings - Fork 135
Add configuration to checkImplicitDependencies suggestion #1591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generate changelog in
|
| sourceClasses = getProject().getObjects().property(FileCollection.class); | ||
| ignore = getProject().getObjects().setProperty(String.class); | ||
| ignore.set(Collections.emptySet()); | ||
| suggestionConfigurationName = getProject().getObjects().property(String.class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure whether it's better to add another property or change the existing sourceClasses property to a SourceSet. I was worried that might be incorrect since that property is annotated with @Classpath.
082aa1a to
2e0c86b
Compare
|
Released 3.61.0 |
Before this PR
The
checkImplicitDependenciessuggestion message does not include the configuration name. This make it cumbersome for users to translate the suggestion to their Gradle configuration.After this PR
The
checkImplicitDependenciessuggestion message includes theimplementationconfiguration name. This allows users to just copy and paste the suggestion into their Gradle configuration.