fix #1471: Error-prone DnsLookup check to prevent unintentional resolution #1472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
ferozco
approved these changes
Aug 19, 2020
Collaborator
|
Released 3.37.0 |
This was referenced Jun 22, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
See palantir/conjure-java-runtime#1736
After this PR
==COMMIT_MSG==
Error-prone DnsLookup check to prevent unintentional resolution
==COMMIT_MSG==
Possible downsides?
There are legitimate cases where one might want to create and resolve an InetSocketAddress, however these cases are relatively rare. This check is meant to provide additional context and guidance so developers can make informed decisions.