Add an id for @VisibleForTesting annotation checks. #1252
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
iamdanfox
reviewed
Feb 21, 2020
.baseline/checkstyle/checkstyle.xml
Outdated
| <property name="lineSeparator" value="lf"/> | ||
| </module> | ||
| <module name="RegexpMultiline"> <!-- Development Practices: Writing good unit tests --> | ||
| <property name="id" value="VisibleForTestingPackagePrivate"/> |
Contributor
There was a problem hiding this comment.
you actually need to make this change to the other checkstyle.xml - this one will get overwritten next time you run ./gradlew baselineUpdateConfig in this repo.
carterkozak
previously approved these changes
Feb 21, 2020
Contributor
|
Should we just migrate this to an errorprone rule? |
Contributor
|
Generally in favor of moving everything we can to errorprone :-) |
Contributor
|
Alternative proposal: #1253 |
Contributor
Author
|
Ah, great @carterkozak! Gonna close since, that should allow me to suppress correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Cannot selectively turn this check off.
After this PR
==COMMIT_MSG==
@VisibleForTesting annotation has an id.
==COMMIT_MSG==
Possible downsides?