Excavator: Upgrades Baseline to the latest version #1226
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamdanfox
reviewed
Feb 10, 2020
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. |
Contributor
There was a problem hiding this comment.
Our thingy should be smart enough to preserve this somehow.
Contributor
There was a problem hiding this comment.
I've just made a PR to separate this out to a new block: #1232
iamdanfox
reviewed
Feb 10, 2020
gradle-junit-reports/src/test/java/com/palantir/gradle/junit/TestCommon.java
Outdated
Show resolved
Hide resolved
svc-excavator-bot
force-pushed
the
roomba/latest-baseline-oss
branch
from
1abcc36 to
3831ba4
Compare
iamdanfox
reviewed
Feb 11, 2020
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * http://www.apache.org/licenses/LICENSE-2.0 |
Contributor
There was a problem hiding this comment.
Argh I think I'm too enthusiastically trimming things- this is supposed to be indented.
(c) Copyright ${today.year} Palantir Technologies Inc. All rights reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
Fix here #1228
iamdanfox
reviewed
Feb 11, 2020
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 |
Contributor
There was a problem hiding this comment.
Still gotta fix this bit 👎
svc-excavator-bot
force-pushed
the
roomba/latest-baseline-oss
branch
from
3831ba4 to
b52c807
Compare
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://url-to-some-license |
Contributor
There was a problem hiding this comment.
great one over here :D
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright 2018 The Error Prone Authors. | |||
Contributor
There was a problem hiding this comment.
I'm not sure this is fine to change
svc-excavator-bot
force-pushed
the
roomba/latest-baseline-oss
branch
from
b52c807 to
131d979
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
excavator is a bot for automating changes across repositories.
Changes produced by the roomba/latest-baseline-oss check.
Release Notes
3.4.0
.baseline/copyright../gradlew test -Drecreate=truewill ensure the"recreate"system property is passed through to Java correctly.3.4.1
3.4.2
To enable or disable this check, please contact the maintainers of Excavator.