Upgrade typescript, swap typedoc dep #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will need to try this in blueprint first because of palantir/blueprint#3574 |
adidahiya
approved these changes
Jul 10, 2019
There was a problem hiding this comment.
tested this on top of palantir/blueprint#3654 and it seems to all work nicely. palantir/blueprint#3574 seems to have resolved itself
|
released and used in palantir/blueprint#3656 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade TypeScript to 3.5.2
Open to discussion on this, but also swapped the
typedocdep for@gerrit0/typedoc, which is cut from master of the same repo but published under a separate namespace. I was thinking we can at least get documentalist on TypeScript 3.5.x for consumers, and then whentypedocfinally releases we can swap it back