Allow configuring the network name for project-based containers #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
docker-proxy-junit-jupiter/src/main/java/com/palantir/docker/proxy/DockerProxyExtension.java
Outdated
Show resolved
Hide resolved
I was hesitant to break back-compat if any client currently asserts that the network looks like they expect. |
| @@ -66,7 +66,24 @@ public static DockerProxyExtension fromProjectName(ProjectName projectName, Clas | |||
| public static DockerProxyExtension fromProjectName( | |||
| ProjectName projectName, Class<?> classToLogFor, String imageNameOverride) { | |||
| return new DockerProxyExtension( | |||
| docker -> new ProjectBasedDockerContainerInfo(docker, projectName, Optional.of(imageNameOverride)), | |||
| docker -> new ProjectBasedDockerContainerInfo( | |||
| docker, projectName, Optional.empty(), Optional.of(imageNameOverride)), | |||
There was a problem hiding this comment.
These parameters are the wrong way around I think
| DockerExecutable docker, | ||
| ProjectName projectName, | ||
| Optional<String> networkNameOverride, | ||
| Optional<String> imageNameOverride) { |
There was a problem hiding this comment.
Can we also do the same here to keep the constructors consistent
SerialVelocity
approved these changes
Mar 29, 2023
|
Released 1.9.0 |
|
For context, a reverse DNS lookup returns the container name with the network name at the end. This is invalid when it contains an underscore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
The default network name generated includes an underscore, which is not always valid.
After this PR
==COMMIT_MSG==
Projects using DockerProxyExtension for project-based containers can now override the docker network name used by the proxy
==COMMIT_MSG==
Possible downsides?