Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use docker compose v2 by default everywhere #744

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Use docker compose v2 by default everywhere #744

merged 2 commits into from
Feb 20, 2024

Conversation

pkoenig10
Copy link
Member

Missed this in #729

@pkoenig10 pkoenig10 requested a review from CRogers February 9, 2024 14:48
CRogers
CRogers reviewed Feb 20, 2024
View reviewed changes
...e-rule-core/src/main/java/com/palantir/docker/compose/execution/DockerComposeExecutable.java
@@ -108,7 +108,7 @@ protected List<String> dockerComposePath() {

@Value.Default
public boolean useDockerComposeV2() {
return false;
return true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely need changelog for a change like this.

Copy link
Member Author

@pkoenig10 pkoenig10 Feb 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already did this intentionally in #729. We just forgot to also change the default here (these classes are structured a bit weird).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh, I still think it's useful for every human authored change to have changelog, it really helps when builds break and you can quickly see what happened.

@changelog-app
Copy link

changelog-app bot commented Feb 20, 2024 •
edited by pkoenig10
Loading

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Use Docker Compose v2 by default when constructing a DockerComposeExecutable explicitly.

Check the box to generate changelog(s)

  • Generate changelog entry

@CRogers
Copy link
Contributor

CRogers commented Feb 20, 2024 •
edited
Loading

👍

@bulldozer-bot bulldozer-bot bot merged commit dfb6fd3 into master Feb 20, 2024
10 checks passed
@bulldozer-bot bulldozer-bot bot deleted the pkoenig/v2 branch February 20, 2024 15:00
@svc-autorelease
Copy link
Collaborator

Released 2.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CRogers CRogers CRogers left review comments

Assignees
No one assigned
Labels
autorelease merge when ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pkoenig10 @CRogers @svc-autorelease @svc-changelog