Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Pin pylint to the last functioning release to unblock contributions #778

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

johnhany97
Copy link
Member

Before this PR

All new runs of CI would pick up pylint major version 3, which is incompatible with the release of pytest-pylint we're relying on causing:

Traceback (most recent call last):
  File "/home/circleci/project/conjure-python-verifier/python/.tox/py3/bin/pytest", line 8, in <module>
    sys.exit(console_main())
  File "/home/circleci/project/conjure-python-verifier/python/.tox/py3/lib/python3.8/site-packages/_pytest/config/__init__.py", line 188, in console_main
    code = main()
  File "/home/circleci/project/conjure-python-verifier/python/.tox/py3/lib/python3.8/site-packages/_pytest/config/__init__.py", line 146, in main
    config = _prepareconfig(args, plugins)
  File "/home/circleci/project/conjure-python-verifier/python/.tox/py3/lib/python3.8/site-packages/_pytest/config/__init__.py", line 325, in _prepareconfig
    config = pluginmanager.hook.pytest_cmdline_parse(
  File "/home/circleci/project/conjure-python-verifier/python/.tox/py3/lib/python3.8/site-packages/pluggy/_hooks.py", line 501, in __call__
    return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult)
  File "/home/circleci/project/conjure-python-verifier/python/.tox/py3/lib/python3.8/site-packages/pluggy/_manager.py", line 119, in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
  File "/home/circleci/project/conjure-python-verifier/python/.tox/py3/lib/python3.8/site-packages/pluggy/_callers.py", line 155, in _multicall
    teardown[0].send(outcome)
  File "/home/circleci/project/conjure-python-verifier/python/.tox/py3/lib/python3.8/site-packages/_pytest/helpconfig.py", line 102, in pytest_cmdline_parse
    config: Config = outcome.get_result()
  File "/home/circleci/project/conjure-python-verifier/python/.tox/py3/lib/python3.8/site-packages/pluggy/_result.py", line 99, in get_result
    raise exc.with_traceback(exc.__traceback__)
  File "/home/circleci/project/conjure-python-verifier/python/.tox/py3/lib/python3.8/site-packages/pluggy/_callers.py", line 102, in _multicall
    res = hook_impl.function(*args)
  File "/home/circleci/project/conjure-python-verifier/python/.tox/py3/lib/python3.8/site-packages/_pytest/config/__init__.py", line 1013, in pytest_cmdline_parse
    self.parse(args)
  File "/home/circleci/project/conjure-python-verifier/python/.tox/py3/lib/python3.8/site-packages/_pytest/config/__init__.py", line 1301, in parse
    self._preparse(args, addopts=addopts)
  File "/home/circleci/project/conjure-python-verifier/python/.tox/py3/lib/python3.8/site-packages/_pytest/config/__init__.py", line 1184, in _preparse
    self.pluginmanager.load_setuptools_entrypoints("pytest11")
  File "/home/circleci/project/conjure-python-verifier/python/.tox/py3/lib/python3.8/site-packages/pluggy/_manager.py", line 414, in load_setuptools_entrypoints
    plugin = ep.load()
  File "/home/circleci/.pyenv/versions/3.8.12/lib/python3.8/importlib/metadata.py", line 77, in load
    module = import_module(match.group('module'))
  File "/home/circleci/.pyenv/versions/3.8.12/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "/home/circleci/project/conjure-python-verifier/python/.tox/py3/lib/python3.8/site-packages/_pytest/assertion/rewrite.py", line 171, in exec_module
    exec(co, module.__dict__)
  File "/home/circleci/project/conjure-python-verifier/python/.tox/py3/lib/python3.8/site-packages/pytest_pylint/plugin.py", line 14, in <module>
    from pylint.config import PYLINTRC
ImportError: cannot import name 'PYLINTRC' from 'pylint.config' (/home/circleci/project/conjure-python-verifier/python/.tox/py3/lib/python3.8/site-packages/pylint/config/__init__.py)

After this PR

==COMMIT_MSG==
Pin pylint to the last functioning release to unblock contributions
==COMMIT_MSG==

This is because in pylint-dev/pylint@3318aa0, the PYLINTRC constant was deleted.

Possible downsides?

@bulldozer-bot bulldozer-bot bot merged commit 78ea33c into develop Feb 7, 2024
6 checks passed
@bulldozer-bot bulldozer-bot bot deleted the jayad/pin-pylint branch February 7, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants