Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: requestBodyFunc handles functions returning nil readers; add RetrieveReaderFromRequestBody #719

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

bmoylan
Copy link
Contributor

@bmoylan bmoylan commented Nov 21, 2024

Fixes failures like this conjure-go test failure: https://app.circleci.com/pipelines/github/palantir/conjure-go/1963/workflows/9d9e8d4a-91e2-4ced-8e6d-dcbef1aca645/jobs/7973/steps

=== RUN   TestBytes/BinaryOptionalAlias_empty
    binary_test.go:112: 
                Error Trace:    /home/circleci/go/src/github.com/palantir/conjure-go/integration_test/testgenerated/binary/binary_test.go:112
                Error:          Received unexpected error:
                                http: Request.ContentLength=-1 with nil Body
                                httpclient request failed map[requestHost:127.0.0.1:33297 requestMethod:Post]
...

This change is Reviewable

@bulldozer-bot bulldozer-bot bot merged commit 2c444eb into develop Nov 21, 2024
5 of 6 checks passed
@bulldozer-bot bulldozer-bot bot deleted the bm/RetrieveReaderFromRequestBody branch November 21, 2024 23:33
@autorelease3
Copy link

autorelease3 bot commented Nov 21, 2024

Released v2.85.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants