fix: NewClientFromRefreshableConfig respects SecurityConfig #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmoylan
commented
Sep 30, 2024
| @@ -225,7 +223,6 @@ func newClientBuilder() *clientBuilder { | |||
| KeepAlive: defaultKeepAlive, | |||
| SocksProxyURL: nil, | |||
| })), | |||
| TLSConfig: defaultTLSConfig, | |||
There was a problem hiding this comment.
Build() will now create a TLSConfigProvider if this is not set.
bmoylan
commented
Sep 30, 2024
| @@ -402,6 +402,12 @@ func newValidatedClientParamsFromConfig(ctx context.Context, config ClientConfig | |||
| HTTP2ReadIdleTimeout: derefPtr(config.HTTP2ReadIdleTimeout, defaultHTTP2ReadIdleTimeout), | |||
| ProxyFromEnvironment: derefPtr(config.ProxyFromEnvironment, true), | |||
| TLSHandshakeTimeout: derefPtr(config.TLSHandshakeTimeout, defaultTLSHandshakeTimeout), | |||
| TLS: refreshingclient.TLSParams{ | |||
There was a problem hiding this comment.
This should have been added in #689 - tests now confirm this config is plumbed through
|
Released v2.83.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression from #689, which now depends on the builder's
b.TLSConfigbeing nil in case we should construct a refreshable provider.This change is