improvement: ServiceName is refreshable #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmiyake
requested changes
Sep 24, 2024
There was a problem hiding this comment.
I know it's a bit of a pain, but would you mind separating the "service name refreshable" change from the rest of the refactors? All of this code is "core" enough that I think it'd be wise to separate out the changes so that, if we need to revert/roll back/debug, we can keep the different PRs isolated.
nmiyake
previously approved these changes
Sep 24, 2024
policy-bot
bot
dismissed
nmiyake’s stale review
Invalidated by push of 013df70
nmiyake
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other no-op refactor/cleanup:
Rename tracing struct fields from Enable to Disable, so zero values work as defaultsRemove unnecessary*conditionalMiddlewareThis change is