[core] fix(NumericInput): increment/decrement with very small step size #6382
Conversation
Rafael-Martins
changed the title
| @@ -30,7 +30,7 @@ function getDecimalSeparator(locale: string) { | |||
| } | |||
|
|
|||
| export function toLocaleString(num: number, locale: string = "en-US") { | |||
| return sanitizeNumericInput(num.toLocaleString(locale), locale); | |||
| return sanitizeNumericInput(num.toLocaleString(locale, { maximumSignificantDigits: 21 }), locale); | |||
There was a problem hiding this comment.
why 21? according to the NumberFormat docs, this should already be the default. maybe you need to adjust a different option like roundingMode?
There was a problem hiding this comment.
I was misunderstanding how it works, I opened a task to enhance the docs in this part https://github.com/mdn/mdn/issues/444 😄
|
|
||
| import { NumericInput } from "../../src"; | ||
|
|
||
| describe("<NumericInput>", () => { |
There was a problem hiding this comment.
there are already tests for this component in packages/core/test/controls/numericInputTests.tsx. can you please move your new tests into that test suite?
| @@ -30,7 +30,7 @@ function getDecimalSeparator(locale: string) { | |||
| } | |||
|
|
|||
| export function toLocaleString(num: number, locale: string = "en-US") { | |||
| return sanitizeNumericInput(num.toLocaleString(locale), locale); | |||
| return sanitizeNumericInput(num.toLocaleString(locale, { roundingPriority: "morePrecision" } as any), locale); | |||
There was a problem hiding this comment.
@Rafael-Martins why do you need to cast as any? I'd prefer to avoid that cast if we can. If it's absolutely necessary, then it should be accompanied with a // HACKHACK: explanation comment on the previous line.
There was a problem hiding this comment.
Hey, sorry, I forgot to send my commentary about it, but the reason is:
I used
as anyhere because this property has not included in the type, I was wondering if we have a better way to do it?Reference: microsoft/TypeScript#52072
I will add the HACKHACK or even try a better approach!
adidahiya
changed the title
| @@ -30,7 +30,7 @@ function getDecimalSeparator(locale: string) { | |||
| } | |||
|
|
|||
| export function toLocaleString(num: number, locale: string = "en-US") { | |||
| return sanitizeNumericInput(num.toLocaleString(locale), locale); | |||
| return sanitizeNumericInput(num.toLocaleString(locale, { roundingPriority: "morePrecision" } as any), locale); | |||
There was a problem hiding this comment.
I used as any here because this property has not included in the type, I was wondering if we have a better way to do it?
Reference: microsoft/TypeScript#52072
| @@ -30,7 +30,7 @@ function getDecimalSeparator(locale: string) { | |||
| } | |||
|
|
|||
| export function toLocaleString(num: number, locale: string = "en-US") { | |||
| return sanitizeNumericInput(num.toLocaleString(locale), locale); | |||
| return sanitizeNumericInput(num.toLocaleString(locale, { maximumSignificantDigits: 21 }), locale); | |||
There was a problem hiding this comment.
I was misunderstanding how it works, I opened a task to enhance the docs in this part https://github.com/mdn/mdn/issues/444 😄
Fixes #4497
Checklist
Changes proposed in this pull request:
Reviewers should focus on:
Screenshot