[datetime] fix: change default max date to 6 months from now #5091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is an inconvenience to use date picker component around end of the year with default value of `maxDate` set to end of the year. Setting the `maxDate` to 6 months from now is a better idea.
|
Thanks for your interest in palantir/blueprint, @UdeshyaDhungana! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
adidahiya
approved these changes
Feb 10, 2022
adidahiya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is an inconvenience to use date picker component around end of the year with default value of
maxDateset to end of the year. Setting themaxDateto 6 months from now is a better idea.Fixes #0000
Checklist
Changes proposed in this pull request:
Default value of
maxDateset to 6 months from now for date picker.Reviewers should focus on:
I don't know what's supposed to go here.
Screenshot