Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icons] feat: new icons "ship", "cargo-ship" #5075

Merged
merged 4 commits into from
Jan 7, 2022

Conversation

jennyfan
Copy link
Contributor

Fixes #0000

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Adds icons ship and ship-cargo

Reviewers should focus on:

Make sure everything renders okay at appropriate sizes, and that the right files were changed.

Screenshot

Screen Shot 2021-12-16 at 6 39 09 PM

if any. -->

@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @jennyfan! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

packages/icons/resources/icons/icons.json Outdated Show resolved Hide resolved
packages/icons/resources/icons/icons.json Outdated Show resolved Hide resolved
packages/icons/resources/icons/icons.json Outdated Show resolved Hide resolved
@adidahiya
Copy link
Contributor

new icons look good in the PR preview, though! 👍🏽

Accepting reviewer changes

Co-authored-by: Adi Dahiya <[email protected]>
Copy link
Contributor Author

@jennyfan jennyfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submitting reviewer changes

Copy link
Contributor Author

@jennyfan jennyfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming files to cargo-ship

@adidahiya adidahiya changed the title feat: new icons - ship, ship-cargo [icons] feat: new icons "ship", "cargo-ship" Jan 7, 2022
@adidahiya adidahiya merged commit 5aad452 into palantir:develop Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants