Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] [core] fix(Tag): fix colors for remove icon in minimal tags #4992

Merged
merged 1 commit into from
Oct 28, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions packages/core/src/blueprint.scss
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ $minimal-dark-tag-intent-colors-modern: (
"primary": ($pt-intent-primary, $blue5, $blue6, $blue6),
"success": ($pt-intent-success, $green5, $green6, $green6),
"warning": ($pt-intent-warning, $orange5, $orange6, $orange6),
"danger": ($pt-intent-danger, $red5, $red1, $red6, $red6)
"danger": ($pt-intent-danger, $red5, $red6, $red6)
);

// Toast variables
Expand Down Expand Up @@ -550,6 +550,7 @@ table.#{$ns}-html-table {
) {
background: $background-color;
color: $text-color;

&.#{$ns}-interactive {
&:hover {
background-color: $hover-color;
Expand Down Expand Up @@ -646,6 +647,14 @@ table.#{$ns}-html-table {
// Contrast for default intent
color: $white;

.#{$ns}-tag-remove {
&,
&:hover,
&:active {
opacity: 1;
}
}

&.#{$ns}-interactive {
&:hover {
background: $dark-gray5;
Expand Down Expand Up @@ -708,6 +717,7 @@ table.#{$ns}-html-table {
// Minimal style for default intent
background-color: rgba($gray3, 0.15);
color: $pt-text-color;

&.#{$ns}-interactive {
&:hover {
background-color: rgba($gray3, 0.3);
Expand All @@ -718,17 +728,17 @@ table.#{$ns}-html-table {
background-color: rgba($gray3, 0.35);
color: $black;
}
}

.#{$ns}-tag-remove > .#{$ns}-icon:first-child {
color: $gray1;
.#{$ns}-tag-remove > .#{$ns}-icon:first-child {
color: $gray1;

&:hover {
color: $dark-gray1;
}
&:hover {
color: $dark-gray5;
}

&:active {
color: $dark-gray1;
}
&:active {
color: $dark-gray5;
}
}

Expand Down