Readonly select items prop #4977
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maclockard
commented
Oct 20, 2021
| @@ -18,7 +18,7 @@ | |||
| * A custom predicate for returning an entirely new `items` array based on the provided query. | |||
| * See usage sites in `IListItemsProps`. | |||
| */ | |||
| export type ItemListPredicate<T> = (query: string, items: T[]) => T[]; | |||
| export type ItemListPredicate<T> = (query: string, items: readonly T[]) => T[]; | |||
There was a problem hiding this comment.
Changing the types of callback arguments may cause compile breaks for consumers, but should be easily fixed, since if they were mutating this argument here, it was probably causing problems
|
closing because it's failing the build. lmk if you want to update & pursue this change again |
|
@adidahiya fixed the build, but needed to open a new PR to get the changes: #5171 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4976
Checklist
Changes proposed in this pull request:
Added readonly annotations to select props
Reviewers should focus on:
The types
Screenshot