Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add z-index to panel stack header #3414

Merged
merged 1 commit into from
Mar 22, 2019
Merged

Add z-index to panel stack header #3414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/core/src/components/panel-stack/_panel-stack.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
display: flex;
flex-shrink: 0;
align-items: center;
z-index: 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we were more consistent about using variables like $pt-z-index-content [1], but I guess we're not, since I see z-index: 1 in a few other places... so this is fine

[1] this feels similar to similar to navbar:

blueprint/packages/core/src/components/navbar/_navbar.scss

Line 37 in 14ce4ac

z-index: $pt-z-index-content;

box-shadow: 0 1px $pt-divider-black;
height: $pt-grid-size * 3;

Expand Down