-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Add position prop to Drawer component, deprecate vertical prop #3386
Merged
adidahiya
merged 6 commits into
palantir:develop
from
Ackos95:as/drawer-enabled-reverse-rendering
Mar 26, 2019
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f93ac26
Added `reverse` prop to Drawer component to enable rendering on rever…
Ackos95 b7c238f
Updated comment on `reverse` prop (`Drawer` component)
Ackos95 f001a38
Changed `reversed` into `reverse` prop on `Drawer`, and small code st…
Ackos95 ad92b27
Merge branch 'develop' into as/drawer-enabled-reverse-rendering
Ackos95 496a3a9
Updated `Drawer` reverse logic to use `Position`, and `vertical` depr…
Ackos95 54b5512
Updated `Drawer` reverse logic to use `{ns}-position-` classes instea…
Ackos95 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,6 +37,14 @@ export interface IDrawerProps extends IOverlayableProps, IBackdropProps, IProps | |
*/ | ||
isOpen: boolean; | ||
|
||
/** | ||
* Whether the drawer should appear on the reversed side. | ||
* Depending on the `vertical` prop, it will show on the left side (instead of the right), | ||
* or on the top (instead of the bottom) | ||
* @default false | ||
*/ | ||
reversed?: boolean; | ||
|
||
/** | ||
* CSS size of the drawer. This sets `width` if `vertical={false}` (default) | ||
* and `height` otherwise. | ||
|
@@ -80,6 +88,7 @@ export class Drawer extends AbstractPureComponent<IDrawerProps, {}> { | |
public static defaultProps: IDrawerProps = { | ||
canOutsideClickClose: true, | ||
isOpen: false, | ||
reversed: false, | ||
style: {}, | ||
vertical: false, | ||
}; | ||
|
@@ -89,8 +98,9 @@ export class Drawer extends AbstractPureComponent<IDrawerProps, {}> { | |
public static readonly SIZE_LARGE = "90%"; | ||
|
||
public render() { | ||
const { size, style, vertical } = this.props; | ||
const classes = classNames(Classes.DRAWER, { [Classes.VERTICAL]: vertical }, this.props.className); | ||
const { size, style, vertical, reversed } = this.props; | ||
const additionalClasses = { [Classes.VERTICAL]: vertical, [Classes.REVERSED]: reversed }; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. just define this object in the |
||
const classes = classNames(Classes.DRAWER, additionalClasses, this.props.className); | ||
const styleProp = size == null ? style : { ...style, [vertical ? "height" : "width"]: size }; | ||
return ( | ||
<Overlay {...this.props} className={Classes.OVERLAY_CONTAINER}> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trailing period please