Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade TSLint-related dependencies #3140

Closed
wants to merge 4 commits into from
Closed

Conversation

adidahiya
Copy link
Contributor

Fixes #3139

@adidahiya
Copy link
Contributor Author

This is trickier than I thought... the latest tslint doesn't seem to be compatible with TS < 2.9 since it relies on a version of tsutils which has type guards for TS 2.9. Based on our experience upgrading TS, I don't want to take 2.9 here in this repo and would rather do a full bump to 3.0.x, but that starts to feel out of scope for this PR...

@giladgray
Copy link
Contributor

typescript 3.0 requires a major version bump, no? for new syntax in declaration files.

@giladgray giladgray self-requested a review November 10, 2018 21:41
@giladgray
Copy link
Contributor

closing till we're ready for ts3

@giladgray giladgray closed this Nov 15, 2018
@adidahiya adidahiya deleted the ad/bump-tslint branch February 5, 2020 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants