Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MenuItem] fix submenu style #2676

Merged
merged 3 commits into from
Jul 11, 2018
Merged

[MenuItem] fix submenu style #2676

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26114aa
fix submenu styles
Jul 10, 2018
b539580
fix submenus styles
Jul 10, 2018
ed464e7
support dark portal menus
Jul 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/core/src/components/menu/_submenu.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@
.#{$ns}-submenu {
> .#{$ns}-popover-wrapper {
display: block;
}

.#{$ns}-popover-target {
display: block;

&.#{$ns}-popover-open > .#{$ns}-menu-item {
// keep a trail of hovered items as submenus are opened
Expand All @@ -16,16 +20,17 @@
}
}

// horizontal padding leaves some space from parent menu item, and extends mouse zone
&.#{$ns}-popover {
box-shadow: none;
// horizontal padding leaves some space from parent menu item, and extends mouse zone
padding: 0 $half-grid-size;

> .#{$ns}-popover-content {
box-shadow: $pt-popover-box-shadow;
}

.#{$ns}-dark & {
.#{$ns}-dark &,
&.#{$ns}-dark {
box-shadow: none;

> .#{$ns}-popover-content {
Expand Down