[MenuItem] submenu tabbing support! #2669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 10, 2018 15:19
inline popover makes for nice easy tab ordering. move Popover onBlur so it captures focus leaving wrapper
support dark portal menusPreview: documentation | landing | table |
| disabled={disabled} | ||
| enforceFocus={false} | ||
| hoverCloseDelay={0} | ||
| interactionKind={PopoverInteractionKind.HOVER} | ||
| modifiers={SUBMENU_POPOVER_MODIFIERS} | ||
| position={Position.RIGHT_TOP} | ||
| usePortal={false} |
There was a problem hiding this comment.
This is a pretty significant difference. You can still do this if you adequately document the change.
|
closing in favor of #2676 to just fix the bug. will revisit later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
MenuItemtabIndexprop, so all menu items (not just those withhrefs) can be tabbed to!onBlurhandler to the wrapper so it captures focus leaving the entire thingusePortal={false}so a submenu will close when tabbing past its last item!