Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain issue with components in the new v3 documentation #2664

Closed
ghost opened this issue Jul 10, 2018 · 2 comments · Fixed by #2676
Closed

Certain issue with components in the new v3 documentation #2664

ghost opened this issue Jul 10, 2018 · 2 comments · Fixed by #2676
Assignees
Milestone

Comments

@ghost
Copy link

ghost commented Jul 10, 2018

  1. In the documentation for the Menu component submenus do behave wrong. The arrows are not aligned right and the submenus have weird left and right borders. Here is a comparison between v3 and v2:
    image
    image
  2. In the documentation for the Navbar component the buttons are raised and not minimal:
    image
  3. Alerts, Dialogs and the Upload File Toast samples do not adhere to the dark theme when enabled in your documentation.
@giladgray giladgray added this to the 3.1.0 milestone Jul 10, 2018
@giladgray
Copy link
Contributor

oof 1 & 2 are definitely regressions, will fix today. thanks!

i cannot repro 3. Alert & Dialog respond just fine to the dark theme. File Toast responds on next update, as expected (because there's no event listener when dark theme is toggled)

@giladgray giladgray self-assigned this Jul 10, 2018
@ghost
Copy link
Author

ghost commented Jul 10, 2018

Issue 3 "resolved itself" - most likely some issue with the stored theme in the local storage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant